fix: Treat certifications like other in-memory states to keep around when pruning. Reverts the revert of async hashing.#10071
Open
michael-weigelt wants to merge 15 commits intomasterfrom
Open
fix: Treat certifications like other in-memory states to keep around when pruning. Reverts the revert of async hashing.#10071michael-weigelt wants to merge 15 commits intomasterfrom
michael-weigelt wants to merge 15 commits intomasterfrom
Conversation
This reverts commit ebfe8f0.
basvandijk
approved these changes
Apr 30, 2026
mraszyk
reviewed
Apr 30, 2026
mraszyk
reviewed
Apr 30, 2026
mraszyk
reviewed
Apr 30, 2026
mraszyk
reviewed
Apr 30, 2026
mraszyk
reviewed
Apr 30, 2026
mraszyk
reviewed
Apr 30, 2026
Contributor
|
Does this intentionally also revert the revert? Can't the fix go in independently? |
mraszyk
reviewed
Apr 30, 2026
mraszyk
reviewed
Apr 30, 2026
Contributor
I think it's better to revert the revert so that we don't need to separate the changes... |
Contributor
That's ok, but then the title and description should reflect that too. |
michael-weigelt
changed the title
eichhorl
reviewed
May 5, 2026
mraszyk
reviewed
May 6, 2026
mraszyk
reviewed
May 6, 2026
mraszyk
reviewed
May 6, 2026
mraszyk
reviewed
May 6, 2026
schneiderstefan
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pruning states below a certain height, we keep around some special heights anyway (such as the
tip_height). This must be true for bothcertification_metadataandcertifications.This also reverts the revert of #8464